Skip to content

Only consider tracked files when building toolchain hashes #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

ahal
Copy link
Collaborator

@ahal ahal commented Mar 25, 2025

Previously we were walking the file system and were e.g scanning files in the .git directory. This can be quite slow on larger repos.

Fixes #663

@ahal ahal requested a review from a team March 25, 2025 16:09
@ahal ahal self-assigned this Mar 25, 2025
@ahal ahal requested a review from hneiva March 25, 2025 16:09
@jcristau
Copy link
Contributor

@glandium fyi

@ahal ahal force-pushed the ahal/push-msspxqnkkmvx branch 2 times, most recently from ef374ea to 3084558 Compare March 25, 2025 16:50
@ahal
Copy link
Collaborator Author

ahal commented Mar 25, 2025

Note that gecko_taskgraph already does this, but it uses FileFinder so I couldn't port the fix exactly.

@ahal ahal force-pushed the ahal/push-msspxqnkkmvx branch from 3084558 to 69df132 Compare March 25, 2025 16:58
@ahal ahal merged commit 5143893 into taskcluster:main Mar 28, 2025
17 checks passed
@ahal ahal deleted the ahal/push-msspxqnkkmvx branch March 28, 2025 20:07
@gregtatum
Copy link
Contributor

Thanks for the work on this, this will be a big quality of life improvement for translations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_get_all_files in util/hash.py very slow on large repos
4 participants